[Expression] add project/ramp_color_object functions #58578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
added
Feature
Expressions
Which contrary to ramp_color doesn't return a string representation there is no rgb conversion involved
Which contrary to project_color doesn't return a string representation there is no rgb conversion involved
troopa81
force-pushed
the
feat_project_ramp_color_object
branch
from
e94e6bd
to
842affb
Compare
troopa81
force-pushed
the
feat_project_ramp_color_object
branch
from
842affb
to
6d4bc26
Compare
zacharlie
added
the
Changelog
|
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
|
@nyalldawson @nirvn May I have a review for this last CMYK PR so CMYK support is complete in 3.40 🙏 ? |
|
@troopa81 I'm on holidays for the rest of the week, I'll get back to reviews next week 👍 |
Thanks! Enjoy your holidays! |
nyalldawson
approved these changes
Oct 1, 2024
DelazJ
added a commit
to qgis/QGIS-Documentation
that referenced
this pull request
Oct 2, 2024
zacharlie
added
ChangelogHarvested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those functions contrary to project/ramp_color doesn't return a string representation so there is no RGB conversion involved. This way we can use CMYK colors.
@nyalldawson @nirvn I failed to come up with a better name, and I really do think that we need another set of functions behaving differently that the old ones. Returning an object only on CMYK color seems hazardous.
Funded by Bordeaux Metropole